D6148: [Icon Applet] Repopulate if URL didn't change

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We used to always delete the backing .desktop file if we changed a property in a Link (to a document) hoping that setUrl would call populate. However, it won't do that if the URL didn't change, so if you only changed the icon, the .desktop file was removed and never re-created, breaking the applet.
  
  BUG: 380922
  FIXED-IN: 5.10.2

TEST PLAN
  (Possibly for 5.8 branch also)
  
  - Dropped app on desktop, clicked it, worked
  - Changed icon for app, worked
  - Changed name for app, worked
  
  - Dropped file on desktop, clicked it, worked
  - Changed icon for file link, now works, didn't before
  - Changed URL for file link, still works

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6148

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170608/281d8b6b/attachment.html>