D6145: Massively simplify the class DesktopPortal

David Edmundson noreply at phabricator.kde.org
Wed Jun 7 22:11:28 UTC 2017


davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Only one QObject can occupt a DBus path...but that object can have
  multiple adaptors, which is how you've structured it anyway.
  
  It's considerably easier than doing everything manually through a
  QDBusVirtualObject

TEST PLAN
  Checked all ifaces registered in qdbusviewer
  Manually ran AddNotification, debug appeared in xdg-desktop-portal and a notification appeared
  
  I haven't actually tested inside flatpak.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6145

AFFECTED FILES
  src/access.cpp
  src/access.h
  src/appchooser.cpp
  src/appchooser.h
  src/desktopportal.cpp
  src/desktopportal.h
  src/email.cpp
  src/email.h
  src/filechooser.cpp
  src/filechooser.h
  src/inhibit.cpp
  src/inhibit.h
  src/notification.cpp
  src/notification.h
  src/print.cpp
  src/print.h
  src/xdg-desktop-portal-kde.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170607/a304b52b/attachment-0001.html>


More information about the Plasma-devel mailing list