D6141: make shadows work for windows 100%width or height

Marco Martin noreply at phabricator.kde.org
Wed Jun 7 17:51:14 UTC 2017


mart added a comment.


  In https://phabricator.kde.org/D6141#114925, @davidedmundson wrote:
  
  > you're written
  >  max(top, bottom, topRight, topLeft)
  >  +
  >  max (left, right)
  >  +
  >  max(bottomLeft, bottomRight, bottom)
  
  
  no, the intention is
  max(left+right,
  
    (max(topLeft,bottomLeft) + max(top,bottom) + max(topright,bottomright))
  
  that is, if topleft+top+topright ==0 and bottomleft+bottom+bottomright == 0,
  then use as pixmap width the width of left+right
  
  (i may even make it more explicit by not doing a max, but just if(width==0) width = left+right

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170607/2facaee4/attachment.html>


More information about the Plasma-devel mailing list