D6141: make shadows work for windows 100%width or height
Marco Martin
noreply at phabricator.kde.org
Wed Jun 7 17:23:17 UTC 2017
mart created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
when a window has 100% width or height (common in the panel),
it disables the shadows on the sides (or top/bottom) and
since they are used to compute width/height, if all 4 corner
shadows are disabled, it will think the resulting shadow pixmap
is null having width or height == 0
in this case, use the width of left and right pixmaps for the width
and height of top and bottom for the height, as they will be the only elements present
TEST PLAN
100% width panels now have a shadow in wayland, kickoff also in
the windowd kwin when it doesn't fit in vertical resolution
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6141
AFFECTED FILES
scene_opengl.cpp
To: mart, #plasma, #kwin, graesslin
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170607/78bc3a12/attachment-0001.html>
More information about the Plasma-devel
mailing list