D6061: prototype of kactivity-based most used modules entries

[David Edmundson]

davidedmundson added a comment.


  Make sure you test with --reverse too

INLINE COMMENTS

> mart wrote in SidebarMode.cpp:163
> I need to remove the kcm: part

Right, but I meant don't call sourceModel()->data(mapToSource....) when you can just call the superclasses data method.

> IntroIcon.qml:32
> +    Layout.fillWidth: true
> +
> +    onClicked: systemsettings.loadMostUsed(index);

You're making a custom button, it needs

http://doc.qt.io/qt-5/qml-qtquick-accessible.html

stuff

> introPage.qml:55
> +        }
> +        width: parent.width * 0.8
> +        Kirigami.Heading {

Math.round()

> introPage.qml:67
> +            Repeater {
> +                model: systemsettings.mostUsedModel
> +                delegate: IntroIcon {

keyboard nav?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D6061

To: mart, #plasma, #vdg
Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170606/054e0ebe/attachment.html>