D6105: [Notification Job Delegate] Slightly optimize summary label

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jun 6 06:20:54 UTC 2017


broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of splitting, just use lastIndexOf and slice.
  This is 2x as fast.

TEST PLAN
  Still shows only file name, I didn't check but I verified that slice(0) would return the entire string (which is when there is no slash, ie. indexOf being -1)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6105

AFFECTED FILES
  applets/notifications/package/contents/ui/JobDelegate.qml

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170606/7955b70d/attachment.html>


More information about the Plasma-devel mailing list