D6088: [Folder View] Use a copy of QMimeData in signal handler
Kai Uwe Broulik
noreply at phabricator.kde.org
Sun Jun 4 14:37:43 UTC 2017
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
By the time we leave the method, the QMimeData is deleted by the DragArea's drop event being destroyed leading to a crash.
BUG: 380806
FIXED-IN: 5.10.1
TEST PLAN
There's no copy operator. Stackoverflow mentions some weirdness on Windows [1] but that shouldn't affect us.
- Can still re-arrange files
- Dropping an external file prompts to copy/link/move/create matching applet and all of those options work now without a crash
[1] https://stackoverflow.com/questions/13762140/proper-way-to-copy-a-qmimedata-object
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6088
AFFECTED FILES
containments/desktop/plugins/folder/foldermodel.cpp
To: broulik, #plasma, hein, fvogt
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170604/f532a3ce/attachment.html>
More information about the Plasma-devel
mailing list