D6047: WIP: Support XDG v6

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xdgshell_interface.h:80
> We need the serial Ids here, otherwise it's not very usable; especially as the pong doesn't have an elapsed time.
> 
> A kjob like API wrapping this might be perfect for here?

so storing all the ids of pings in progress somewhere to make a more recent ping not cancel an older one still pending?

> davidedmundson wrote in xdgshell_interface_p.h:41
> I don't understand this timer, all it's used for is for making us not emit a pong if it comes in after a timeout?

send ping, if a pong doesn't arrive after a timeout, consider it dead.. I copied it as-is from wl_shell iirc, so assumed this would be the expected behavior.

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170601/1da3cb15/attachment.html>