D6055: Don't call setDefaultSink/Source when already default

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Checked state changes are not correctly handled in default device
  QtQuickControls checkbox in KCM (changes are applied also for non-user
  initiated, eg. on component complete).
  This triggers setting the default device when opening KCM which moves all
  streams to that device, and it breaks any previous manual configuration
  (moving streams to different devices).
  
  Make sure we call setDefaultSink/Source only when the default device
  is actually different.
  
  BUG: 380414
  FIXED-IN: 5.10.1

TEST PLAN
  No more unnecessary setDefaultSink/Source calls on opening KCM.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6055

AFFECTED FILES
  src/sink.cpp
  src/source.cpp

To: drosca, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170601/dcf1a217/attachment.html>