Review Request 130205: View Styles

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130205/#review103488
-----------------------------------------------------------



Why?

The mode chooser is hidden well enough that it doesn't produce visual noise and not a lot of extra burden on the user (since there's UI for switching anyway, 2 or 3 options doesn't make it a lot lighter). Moreover, the tree view is something users seem to actually like and use, and the code for it has aged well and doesn't require maintenance, so it's not a lot of technical debt to carry around.


This patch doesn't remove the actual code, it just removes the entry which essentially leaves dead code around, so the patch is technically insufficient.

- Sebastian Kügler


On July 26, 2017, 9:54 p.m., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130205/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 9:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> as system settings has now 3 different views the classic should be removed from the tree view in configure dialogue.
> 
> 
> Diffs
> -----
> 
>   classic/settings-classic-view.desktop 57cd2a3 
> 
> Diff: https://git.reviewboard.kde.org/r/130205/diff/
> 
> 
> Testing
> -------
> 
> none.
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170728/03d722a9/attachment.html>