D6718: Fix occasional abort in the krunner plugin

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Jul 27 15:01:49 UTC 2017


broulik added a comment.


  @davidedmundson Should we go with this now?

INLINE COMMENTS

> tabsrunner.cpp:103
>  
> -        if (reply.type() != QDBusMessage::ReplyMessage) {
> +        if (reply.type() != QDBusMessage::ReplyMessage || reply.arguments().length() < 1) {
>              continue;

Perhaps even check `!= 1` - it shouldn't have more than one argument either.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D6718

To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170727/e2a6ca96/attachment.html>


More information about the Plasma-devel mailing list