D6571: Delete all Wayland connections by plugins prior to own Wayland connection

David Edmundson noreply at phabricator.kde.org
Sat Jul 15 19:50:20 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> wayland_server.cpp:93
>      if (m_internalConnection.client) {
> +        // delete all connections hold by plugins like e.g. widget style
> +        const auto connections = KWayland::Client::ConnectionThread::connections();

s/hold/held.

> wayland_server.cpp:99
> +            }
> +            delete c;
> +        }

Alternative.

Instead of deleting qobjects

emit c->connectionDied();

Clients then call destroy() on whatever objects.
They can then delete the QObjects whenever they were going to.

REPOSITORY
  R108 KWin

BRANCH
  connection-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D6571

To: graesslin, #kwin, #plasma, mart
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170715/08a91ed7/attachment-0001.html>


More information about the Plasma-devel mailing list