D6708: Properly swap the quick tile side when pressing the shortcut again

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The quick tile shortcuts have a feature of moving the window to the next
  screen if one presses the same shortcut again.
  E.g. if a window is quick tiled to the left on the right most screen,
  quick tile again to left should move it to the left screen and quick tile
  right. Thus it swaps the borders.
  
  This wasn't handled correctly, especially not for modes like top and
  bottom. If a window is quick tiled to the top an impossible mode was
  generated: Left | Right. Doesn't make sense.
  
  This change fixes the mode swapping and extends our quick tile testing
  to cover the situation.
  
  BUG: 382313
  FIXED-IN: 5.10.4

TEST PLAN
  Extended test case

REPOSITORY
  R108 KWin

BRANCH
  fix-quick-tile-swap-side-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6708

AFFECTED FILES
  autotests/integration/quick_tiling_test.cpp
  geometry.cpp

To: graesslin, #plasma, #kwin
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170715/2895cf40/attachment.html>