D6673: [Notifications] Manually remove remote images

[David Edmundson]

davidedmundson added a comment.


  Addressing the text first:
  
  > The network access manager factory we install is ineffective as Plasma uses a shared engine nowadays and whenever a new QmlObject shared engine is created, its setupBindings will re-install the KIO access factory.
  
  There used to be a .desktop flag for that..
  
  > (Btw I noticed that setupBindings is called >100 times on Plasma startup, setting up the very same QML engine over and over again, including creating a KIO NAM factory, KLocalizedContext and KIcon image provider)
  
  calling setupBindings() is needed as we install the ki18n on the context (which is different), but you're right that the stuff with the engine could indeed be done once.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170714/b367b008/attachment-0001.html>