D6673: [Notifications] Manually remove remote images

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> textsanitizer.cpp:45
> +    for (int i = 0; i < newDocument->blockCount(); ++i) {
> +        QTextBlock block = newDocument->findBlock(i);
> +

(Already noted on IRC)

This doesn't do what it's intended to do, `findBlockByNumber` is needed here.
Otherwise it only goes through the first few blocks and leaves the rest as-is:

> notify-send "a" "<span>a</span><div>a</div><div>b</div><img src='http://localhost'/>"

results in

> file:///usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationItem.qml:268:17: QML TextEdit: localhost: Connection refused

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170714/d5e80e3a/attachment.html>