D6697: Allow to change toolbar font separately again

[Henrik F.]

rkflx created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The fonts KCM supports changing the toolbar font, but with the port to
  QPA/Plasma 5 in https://phabricator.kde.org/R446:aa16577f402549c73721164aa45141caff774142 this stopped working and toolbars just used the
  general font. This is fixed by setting QPlatformTheme's ToolButtonFont
  to the toolbar font chosen. However, there are some caveats:
  
  - Default toolbar font size is 9, while the general font size is 10.
  
  This would result in a sudden shrink in toolbar widths everywhere (or
  worse for weird leftover settings users might have tried unsuccessfully).
  
  - In some places QToolButtons are used outside of toolbars, sometimes
  
  right next to QPushButtons. As due to the bug both had the same font,
  this might now lead to unexpected differences.
  
  Therefore, to keep visual consistency with past Plasma 5 releases, let's
  change the default toolbar font size to 10 and provide a kconf_update
  script to copy the general font to the toolbar font once. This should
  give us some time to fix fonts of single QToolButtons and discuss with
  the https://phabricator.kde.org/tag/vdg/ whether to leave the default toolbar font size at 10 or change
  it back to 9 with a major release as originally intended.
  
  BUG: 358254

TEST PLAN
  - sudo make install, verify *.{so,upd,pl} are in the same location as
  
  the regularly installed files: toolBarFont in kdeglobals gets updated
  immediately
  
  - Change "Toolbar" font in "kcmshell5 fonts", start your favorite KDE
  
  and Qt-only applications: toolbar font and/or font size changed
  accordingly

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6697

AFFECTED FILES
  src/platformtheme/CMakeLists.txt
  src/platformtheme/fonts_global_toolbar.pl
  src/platformtheme/fonts_global_toolbar.upd
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kfontsettingsdata.cpp

To: rkflx, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170714/0c960dbf/attachment-0001.html>