D6634: Require C++14

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  It is undefined behaviour to extend std:: namespace in this way. You should go for this instead:
  
    #if ...
        template ... make_unique ...
    #else
        using std::make_unique;
    #endif
  
  p.s. Another potential problem is that it might happen that a compiler supports a core language from C++XX while the library implementation is behind. But I guess most platforms use libstdc++/gcc so that might not be a problem for kwin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6634

To: graesslin, #plasma, lbeltrame, ivan
Cc: ivan, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170711/1b032f46/attachment.html>