D6608: [PlasmaComponents Menu] Don't crash on null action

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> qmenuitem.cpp:47
> +                m_hasExplicitAction = true;
> +                delete m_action;
> +                m_action = nullptr;

Why delete it?

  if (!a) {
      setVisible(false);
      return;
  }
  // m_action stays last one, but disconnected. And we want to have last one "inactive"?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6608

To: broulik, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170710/82e1fd60/attachment-0001.html>