D6565: Query supported OpenGL core profile version on X11, GLX
Michal MalĂ˝
noreply at phabricator.kde.org
Sun Jul 9 10:56:22 UTC 2017
madcatx updated this revision to Diff 16377.
madcatx added a comment.
v2. The code now tries to leverage GLX_MESA_query_renderer when it is available and falls back to the old-fashioned probing otherwise. As for some of the suggestions by Martin:
- The new code now uses nullptrs instead of NULLs
- qCDebug() does not seem to be used anywhere in the whole kinfocenter so I cannot simply replace qDebug()s with their qCDebug() counterparts without declaring the logging category first.
- As for the GlxContext builders, is it worth it to pull in some KWin dependencies just to query the OpenGL core profile? Currently the kinfocenter does not seem to depend of KWin in any way.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6565?vs=16331&id=16377
REVISION DETAIL
https://phabricator.kde.org/D6565
AFFECTED FILES
Modules/opengl/opengl.cpp
To: madcatx, graesslin
Cc: fredrik, graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170709/b399bd70/attachment.html>
More information about the Plasma-devel
mailing list