D6573: Babelfish plugin: Allow secure URLs to be translated

[Jonathan Marten]

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Dolphin, plasma-devel.

REVISION SUMMARY
  The plugin originally only allows HTTP URLs to be translated.  With the increasing use of automatic redirection to HTTPS, this seriously restricts the utility of the plugin - neither www.kde.org nor Wikipedia can be translated.
  
  This change enables the plugin for HTTPS URLs also.  Since this can result in secure information being transmitted over the network in clear text and received by the online translation service, a warning dialogue (with the option to not ask again) is shown.
  
  The change also removes some unused header files and ports KUrl -> QUrl, which eliminates the use of KDELibs4Support.

TEST PLAN
  Built konqueror with this change, checked operation of Tools - Translate Web Page for www.kde.org and other secure pages.

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6573

AFFECTED FILES
  plugins/babelfish/CMakeLists.txt
  plugins/babelfish/plugin_babelfish.cpp
  plugins/babelfish/plugin_babelfish.h

To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170708/d00e7ef8/attachment-0001.html>