D6565: Query supported OpenGL core profile version on X11, GLX

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I highly suggest to use the new context attribute builder I created for KWin. See https://phabricator.kde.org/D6411

INLINE COMMENTS

> opengl.cpp:778
> +   } else {
> +      qDebug() << "Error: glXMakeCurrent failed for core profile\n";
> +   }

Please don't add qDebug in new code, use qCDebug instead. Same of course for all the other cases in the change.

> opengl.cpp:788-789
>     XVisualInfo *visinfo;
> +   GLXContext ctxCoreProf = NULL;
> +   GLXFBConfig *fbcCoreProf = NULL;
>     int width = 100, height = 100;

please use nullptr in new code.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D6565

To: madcatx, graesslin
Cc: graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170708/1893e166/attachment.html>