D6555: [Applet Alternatives] Set applet status to RequiresAttentionStatus while open

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jul 7 15:18:40 UTC 2017


broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the panel stays visible while applet alternatives dialog is open.
  It also works around a quirk in Plasma Dialog which won't show if visualParent is in a auto-hidden panel.
  
  BUG: 347855
  BUG: 352459

TEST PLAN
  Opened applet alternatives for TM in auto hidden panel, alternatives showed up and kept panel open. Panel auto-hid again once closed. Before the alternative dialog wouldn't even show up.
  
  You get a brief flicker of the panel starting to hide while the QML is being processed but it's an improvement over the status quo in any way.
  
  I tried to figure out why Dialog behaves weird (if I didn't set visualParent to `alternativesHelper.applet` which is in an auto-hidden panel it worked) but I got lost in there. I know that the dialog's position was properly determined but then somewhere it got confused.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6555

AFFECTED FILES
  shell/alternativeshelper.cpp
  shell/alternativeshelper.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170707/d92aeb00/attachment-0001.html>


More information about the Plasma-devel mailing list