D6544: Don't draw focus line on selected list item

Christoph Feck noreply at phabricator.kde.org
Fri Jul 7 12:08:20 UTC 2017


cfeck added inline comments.

INLINE COMMENTS

> broulik wrote in breezestyle.cpp:3082
> From what I can tell the difference is negligible. `qobject_cast` goes through `QMetaObject::cast` which then calls `inherits` internally, so I'd say `inherits` is the better choice.
> 
> I didn't benchmark, though. I just followed what the rest of the code around it was doing (`inherits`)

Of course inherits(QString) is slower than qobject_cast<>.

The only reason to use inherits() is when you do not link to the library that the class defines.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170707/a221e79c/attachment.html>


More information about the Plasma-devel mailing list