D6544: Don't draw focus line on selected list item

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jul 7 10:22:13 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezestyle.cpp:3082
> Not sure which one is the most efficient:
> Widget->inherits or qobject_cast ?
> (My guess  would need the second, but ...)
> Can you double check ?

>From what I can tell the difference is negligible. `qobject_cast` goes through `QMetaObject::cast` which then calls `inherits` internally, so I'd say `inherits` is the better choice.

I didn't benchmark, though. I just followed what the rest of the code around it was doing (`inherits`)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D6544

To: broulik, #plasma, hpereiradacosta, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170707/dabe26e9/attachment.html>


More information about the Plasma-devel mailing list