D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Jul 6 14:40:15 UTC 2017
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This ensures the panel does not auto-hide then.
It also forces a re-evaluation of auto-hide status when the menu closes, so even if we mess up with mouse grabbing, it should more reliably auto-hide afterwards.
BUG: 344205
CCBUG: 351823
TEST PLAN
Right clicked a couple of applets, panel stayed visible while the menu was open. It auto-hid again when I closed the menu.
Task Manager needs a separate patch but this should be fairly trivial, something like `Plasmoid.status: contextMenu && contextMenu.status === PlasmaCore.Dialog.Open ? PlasmaCore.Types.RequiresAttentionStatus : PlasmaCore.Types.ActiveStatus`
I tried meddling with `focusWindow` and `applicationState` but I never got a meaningful change in the two when the context menu closed, so I chose this crude approach
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6527
AFFECTED FILES
src/scriptengines/qml/plasmoid/containmentinterface.cpp
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170706/26427967/attachment.html>
More information about the Plasma-devel
mailing list