D3805: Per-activity favorites (Final, again?)

[Marco Martin]

mart added a comment.


  I tried the patch, and i'm getting a crash as well, tough a bit different:
  #0  0x00007fff39b74cf5 in KAStatsFavoritesModel::Private::removeOldCachedEntries() const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #1  0x00007fff39b7377a in KAStatsFavoritesModel::isFavorite(QString const&) const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #2  0x00007fff39b96814 in InvalidAppsFilterProxy::filterAcceptsRow(int, QModelIndex const&) const ()
  
    from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  
  #3  0x00007ffff0e2892a in QSortFilterProxyModelPrivate::create_mapping (this=0x1188af0, source_parent=...) at itemmodels/qsortfilterproxymodel.cpp:343
  #4  0x00007ffff0e2e7e4 in QSortFilterProxyModel::rowCount (this=0x1188ac0, parent=...) at itemmodels/qsortfilterproxymodel.cpp:1878
  #5  0x00007fff39b784f1 in ForwardingModel::rowCount(QModelIndex const&) const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #6  0x00007fff39b5bbf3 in AbstractModel::count() const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #7  0x00007fff39b88b87 in GroupEntry::hasChildren() const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #8  0x00007fff39b64a65 in AppsModel::data(QModelIndex const&, int) const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #9  0x00007fff39b89130 in RootModel::data(QModelIndex const&, int) const () from /opt/kde5/qml/org/kde/plasma/private/kicker/libkickerplugin.so
  #10 0x00007ffff452c63b in QModelIndex::data (this=0x7fffffff5ff0, arole=263)
  
    at /home/diau/git/qt5/qtbase/include/QtCore/../../src/corelib/itemmodels/qabstractitemmodel.h:432
  
  #11 0x00007ffff452f08e in QQmlDMAbstractItemModelData::value (this=0x2b751e0, role=263) at util/qqmladaptormodel.cpp:420
  #12 0x00007ffff4529d3a in QQmlDMCachedModelData::metaCall (this=0x2b751e0, call=QMetaObject::ReadProperty, id=12, arguments=0x7fffffff6150)
  
    at util/qqmladaptormodel.cpp:292
  
  #13 0x00007ffff452ee7a in VDMModelDelegateDataType::metaCall (this=0x2b6e7f0, object=0x2b751e0, call=QMetaObject::ReadProperty, id=12, arguments=0x7fffffff6150)
  
    at util/qqmladaptormodel.cpp:249
  
  #14 0x00007ffff0e6dfef in QMetaObject::metacall (object=0x2b751e0, cl=QMetaObject::ReadProperty, idx=12, argv=0x7fffffff6150) at kernel/qmetaobject.cpp:299
  #15 0x00007ffff4744682 in QQmlPropertyData::readPropertyWithArgs (this=0x2b77f68, target=0x2b751e0, args=0x7fffffff6150)
  
    at ../../include/QtQml/5.8.1/QtQml/private/../../../../../src/qml/qml/qqmlpropertycache_p.h:312
  
  #16 0x00007ffff47445c5 in QQmlPropertyData::readProperty (this=0x2b77f68, target=0x2b751e0, property=0x7fffffff61d0)
  
    at ../../include/QtQml/5.8.1/QtQml/private/../../../../../src/qml/qml/qqmlpropertycache_p.h:302
  
  #17 0x00007ffff473b2eb in loadProperty (v4=0x804360, object=0x2b751e0, property=...) at jsruntime/qv4qobjectwrapper.cpp:166
  #18 0x00007ffff473c003 in QV4::QObjectWrapper::getProperty (engine=0x804360, object=0x2b751e0, property=0x2b77f68, captureRequired=true)
  
    at jsruntime/qv4qobjectwrapper.cpp:316
  
  #19 0x00007ffff473bc6e in QV4::QObjectWrapper::getQmlProperty (this=0x7fffd9b9d638, qmlContext=0x2be2a80, name=0x7fffd9b9d630,
  
    revisionMode=QV4::QObjectWrapper::IgnoreRevision, hasProperty=0x0, includeImports=true) at jsruntime/qv4qobjectwrapper.cpp:279
  
  #20 0x00007ffff473e046 in QV4::QObjectWrapper::get (m=0x7fffd9b9d638, name=0x7fffd9b9d630, hasProperty=0x0) at jsruntime/qv4qobjectwrapper.cpp:625
  #21 0x00007ffff46107b3 in QV4::Object::get (this=0x7fffd9b9d638, name=0x7fffd9b9d630, hasProperty=0x0)
  
    at ../../include/QtQml/5.8.1/QtQml/private/../../../../../src/qml/jsruntime/qv4object_p.h:326

REVISION DETAIL
  https://phabricator.kde.org/D3805

To: ivan, mart, hein
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170705/b231cf8d/attachment-0001.html>