[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

[James Lee]

https://bugs.kde.org/show_bug.cgi?id=363147

--- Comment #3 from James Lee <james at james.tl> ---
36 px isn't good enough and here's why:

You have a whole class of laptops with 14" 2560x1440 (WQHD) displays, such as
the Lenovo ThinkPad T4*0/X* line of laptops that are very popular in the Linux
community.  These screens require a scaling factor of 1.67 (that's one and two
thirds), which would make a (24 * 1.67 =) 40 px cursor look right.

You may ask, "what difference does 4 pixels make?"  Well that's 10%, and it's
instantly noticeable, especially when highlighting lines relative to normal
text height.  See the attached screenshots.

You might say, "well having 24, 32, 36, 40, and 48 is too many confusing
choices."  But users are used to making choices like that for fonts, where
sizes like 24, 32, 36, 40, and 48 are common.

You might say, "well having that many sizes increases the size of the resulting
binaries installed on the system."  To that I say adding sizes 32 and 40 in
addition to 36 increases the total size of both Breeze and Breeze_Snow combined
by just 625 KB.

You might say, "well, managing all of those sizes is kind of ugly with our
build scripts."  But if you had actually looked at my patch, you would have
seen that I completely refactored the build script to support arbitrarily many
sizes, and also support building arbitrarily many cursors (so that you don't
have to duplicate the build script across both the Breeze and Breeze_Snow
cursors).

Please reconsider my patch.

Also, I take sincere objection to your suggestion that I didn't submit my
contribution properly.  I have contributed to a lot of open-source projects
before.  This is a bug so I submitted a bug report and made it perfectly clear
in the bug report title that I included a patch.  The patch had a lot of binary
data, so rather than upload it to Bugzilla, I chose to link to it on GitHub,
where there is an official mirror of the Breeze repository.  If you don't want
people using GitHub, either don't mirror the repo on GitHub, or include a
CONTRIBUTING file in the repository so community members know how to submit
contributions.

Furthermore, you are the KDE dev, not me.  You should have seen this; I mean,
it's been eight months!  It is your job to look at and respond to Bugzilla
bugs, and shepherd community contributions through your SDLC, of which I am
unfamiliar, especially because there is no CONTRIBUTING file in the repository!

Your apparent dismissal of my well-crafted (and personally time-consuming)
contribution is offensive and makes me less likely to contribute to KDE
projects.

Please reconsider my patch.  Again, it's at
https://github.com/iamjamestl/breeze/compare/master...iamjamestl:cursor-build-multiple-sizes.patch
in standard Git unified diff format, regardless of where it's hosted.  If you
need me to rebase it again, I can.

Thanks,

James

-- 
You are receiving this mail because:
You are the assignee for the bug.