[Differential] [Request, 4 lines] D4350: [FrameData] Avoid iterating keys()

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Instead use iterators. Could be changed to using keyBegin or something like that potentially.
  
  The destructor is called 400 times on plasmashell startup for me.
  Before: 250,000ns
  After: 110,000ns

TEST PLAN
  It's interesting that there's so many FrameData objects that are created and destroyed on startup.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4350

AFFECTED FILES
  src/plasma/framesvg.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170130/3dfc09b2/attachment.html>