[Differential] [Request, 6 lines] D4349: [Shell Corona] Avoid iterating keys() and then doing a value() lookup

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use iterators and their key() and value() methods.
  
  This codepath is hit 200+ times on plasmashell startup for me
  Before: 420,000 µs
  After: 200,000 µs

TEST PLAN
  Still looking good, notification popup positioned correctly and whatnot.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4349

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170130/ba95b8b0/attachment.html>