[Differential] [Changed Subscribers] D4344: Delay setting the model on the view until listing is finished.

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:189
>                      if (applet.busy) {
> +                        console.log("busy");
>                          busyLoader.source = "BusyOverlay.qml"

Remove

> foldermodel.cpp:121
> +    connect(dirLister, &KCoreDirLister::started, this, &FolderModel::listingStarted);
> +    void (KCoreDirLister::*myCompletedSignal)() = &KCoreDirLister::completed;
> +    QObject::connect(dirLister, myCompletedSignal, this, &FolderModel::listingCompleted);

We usually just cast inline in the connect

`connect(dirLister, static_cast<void(KCoreDirLister::*)()>(&KCoreDirLister::completed), this, &FolderModel::listingCompleted);`

> foldermodel.h:63
>          void error(const QString &string);
> +        void completed();
>  

I can see this being connected to but where is it emitted?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4344

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170130/cf65f78c/attachment.html>