[Differential] [Commented On] D4301: [System Tray] SNI fallback to context menu on failing Activate

[Anthony Fieroni]

anthonyfieroni added a comment.


  > - Guard code execution in `StatusNotifierItemSource::activate` against deleted `m_statusNotifierItemInterface` by comparing it to the old pointer value
  
  You can't do that in this way, do this
  
    QPointer<org::kde::StatusNotifierItem> snii = m_statusNotifierItemInterface;
    if (snii && snii->isValid()) {
        emit activateCallback(!snii->lastError().isValid());
    }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4301

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, davidedmundson
Cc: anthonyfieroni, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170128/726a8c31/attachment.html>