[Differential] [Request, 27 lines] D4309: fix isOutputRedundant logic

Marco Martin noreply at phabricator.kde.org
Fri Jan 27 13:57:06 UTC 2017


mart created this revision.
mart added reviewers: Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  isOutputRedundant badly failed when two screens had
  the exact same geometry (that should be, the base
  case for "cloning" screens.
  now the logic is:
  a screen is redundant if:
  
  - its geometry is contained in another one
  - if their resolutions are different, the "biggest" one wins
  - if they have the same geometry, the one with the lowest id wins (arbitrary, but gives reproducible behavior and makes the primary
  
  BUG:375507

TEST PLAN
  tested with two screens:
  
  - overlapping, same resolution: the lowest id (0, the primary) wins, the other one doesn't get a view
  - overlapping, different resolutions: the biggest one wins
  - not overlapping: both get a view

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/redundant

REVISION DETAIL
  https://phabricator.kde.org/D4309

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170127/207f6d81/attachment-0001.html>


More information about the Plasma-devel mailing list