Review Request 129872: [lookandfeel] Support changing window decoration

[Anthony Fieroni]

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?
> 
> Anthony Fieroni wrote:
>     I made in same approach like other roles and i commit defaults (in blocks)
> 
> Martin Gräßlin wrote:
>     But Marco already implemented that, didn't he? That's why I don't understand your change.
> 
> Anthony Fieroni wrote:
>     This is rebase over Marco's changes. If he told me to discard it i will, for it's needed.
> 
> Martin Gräßlin wrote:
>     So I don't understand what your change does what Marco's change doesn't do already. What I see is that you rebased, but why and what for?
> 
> Anthony Fieroni wrote:
>     Reading 'defaults' by theme isn't done. By this patch or Marco by yourself should do it explicitly
> 
> Marco Martin wrote:
>     I still don't understand the patch, the group that kwin reads is org.kde.kdecoration2 and not windowDecoration, no?

In kwinrc yes, but i should get it from defaults e.g. breeze - plasma-workspace/lookandfeel/contents/defaults, oxygen - oxygen/lookandfeel/contents/defaults
I push there [kwinrc][WindowDecoration]
When user select different look'n'feel e.g. from breeze to oxygen, the code reads configuration from 'defaults' file in the selected theme.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
-----------------------------------------------------------


On Jan. 24, 2017, 10 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 10 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h c27b7f3d 
>   kcms/lookandfeel/kcm.cpp 6ea3d050 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170127/876e6f9f/attachment-0001.html>