[Differential] [Request, 21 lines] D4301: [System Tray] SNI fallback to context menu on failing Activate

[Roman Gilg]

subdiff created this revision.
subdiff added reviewers: Plasma, davidedmundson.
subdiff set the repository for this revision to R120 Plasma Workspace.
subdiff added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This patch primarily is aimed at applications using libappindicator. For example:
  
  - Steam
  - Discord
  - Deluge
  
  libappindicator doesn't provide functionality for raising an application, but only a context menu. Since it also doesn't even provide the corresponding DBus method, we use the resulting error to try to display the context menu instead, which matches the behaviour on Unity and Gnome.
  
  https://www.gamingonlinux.com/forum/topic/2519
  https://bugs.kde.org/show_bug.cgi?id=375351

TEST PLAN
  Manually with libappindicator and Qt based tray icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4301

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  dataengines/statusnotifieritem/statusnotifieritemjob.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170126/ad337c1d/attachment.html>