[Differential] [Request, 4 lines] D4285: When swapping Wallpapers, save the config to file, not just to propertymap

David Edmundson noreply at phabricator.kde.org
Wed Jan 25 21:33:12 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ContainmentConfigView has a special code path for wallpaper configs
  where, if you change wallpaper type, it will create a temporary config
  ConfigPropertyMap, then copy it over to the real config when the
  containment actually changes.
  
  ConfigPropertyMap does not call valueChanged() on insertion (See
  QQmlPropertyMap), and we only write the value into the actual
  KConfigSkeleton on valueChange.
  
  BUG: 375532

TEST PLAN
  Start plasma with image wallpaper
  Set to colour wallpaper and save colour
  Hit apply
  
  Close plasma
  Start plasma
  
  Before the correct colour wouldn't be loaded. Now it is.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4285

AFFECTED FILES
  shell/containmentconfigview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/5e309983/attachment.html>


More information about the Plasma-devel mailing list