[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> iconapplet.cpp:108
> +        if (desiredDesktopFileName.isEmpty()) {
> +            desiredDesktopFileName = QString::fromLatin1(QCryptographicHash::hash(m_url.toDisplayString().toUtf8(), QCryptographicHash::Md5).toHex());
> +        }

Not convinced that KIO::encodeFileName would be better than a MD5 filename, then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/d4ef5309/attachment-0001.html>