[Differential] [Changed Subscribers] D4269: VolumeSlider: Ignore all value changes until Component is completed

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ListItemBase.qml:176
>  
>                          onValueChanged: {
>                              if (!ignoreValueChange) {

can you not just add

if (Component.status != Ready) to the top of this method

and get rid of the bool?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4269

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170124/43cbaa75/attachment.html>