[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:59
> +                        appletContainer.anchors.leftMargin +
> +                        appletContainer.anchors.rightMargin - handleWidth);
> +    }

why are you including handleWidth here?

>From what I can see in the code; 
appletItem should be the the size of the applet + normal margins

Then on line 290 it creates a container that's bigger than the parent item and does include  the handle

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170123/68286a42/attachment.html>