Review Request 129872: [lookandfeel] Support changing window decoration

[Marco Martin]

> On Jan. 22, 2017, 4:19 p.m., Martin Gräßlin wrote:
> > Marco quite recently implemented this:
> > 
> > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937
> 
> Anthony Fieroni wrote:
>     Maybe it should be backported to 5.8?
> 
> Martin Gräßlin wrote:
>     No, clearly not. This is a new feature and not a bug fix.
> 
> Anthony Fieroni wrote:
>     This is not a discussion but it's done on different way than others e.g. we can't set oxygen deco. Oxygen look'n'feel feels broken, i want to fix it.

uuh, no, simply in 5.8 it doesn't support changing the window decoration, is simply a feature that isn't there, therefore shouldn't be added on bugfix releases.
-1 for backporting.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102179
-----------------------------------------------------------


On Jan. 22, 2017, 1:05 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129872/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 1:05 p.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
>   kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
>   kcms/lookandfeel/kcm.h 16df7fde 
>   kcms/lookandfeel/kcm.cpp a8ceca20 
> 
> Diff: https://git.reviewboard.kde.org/r/129872/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170122/d36d63df/attachment.html>