[Differential] [Request, 21 lines] D4218: Remove pointless QObject inheritance in model item
David Edmundson
noreply at phabricator.kde.org
Fri Jan 20 03:13:47 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We don't emit anything or use properties or anything else that requires
MOC. We want to keep model items light.
The emitDataChanged in setRunning still works because that's part of
QStandardItem. Memory management is the same beacuse the
QStandardItemModel takes ownership in appendRow().
TEST PLAN
Opened widget explorer.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4218
AFFECTED FILES
components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp
components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170120/c65d552a/attachment.html>
More information about the Plasma-devel
mailing list