[Differential] [Request, 61 lines] D4217: Remove unused feature "favorite" from PlasmaAppletItemModel

David Edmundson noreply at phabricator.kde.org
Fri Jan 20 03:07:01 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There was no role exposed for isFavorite and it has no other impact.
  Removing it not only cleans up the code but also saves us parsing a
  config file for no reason.
  
  I don't think it's worth putting in the UI; no-one is adding so many
  plasmoids that they would go out of their way to mark one as a favourite
  for quicker future access.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4217

AFFECTED FILES
  components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp
  components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170120/221e8fe8/attachment-0001.html>


More information about the Plasma-devel mailing list