[Differential] [Request, 261 lines] D4202: use proper packagestructures

Marco Martin noreply at phabricator.kde.org
Thu Jan 19 17:33:19 UTC 2017


mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  as the plasmapkg2 utility is dead, scripts and tabboxes couldn't
  be installed anymore, as plasmapkg2 was launched with an hardcoded
  package type (and had a bunch of custom code for it)
  and no packagestructure for the relevant package types existed.
  
  the port of scripts and tabboxes to kpackage in kwin is quite
  incomplete and somewhat strange (given the fact that was started by
  looking manually for the file as it couldn't link to libplasma)
  
  this makes things a bit better as now scripts and tabboxes have an actual
  package structure, making it installable by kpackagetool5.
  in the future, the port should be completed and replace all the manual lookup
  of files with package::filePath as it should work now given that valid
  structures exist
  
  BUG:374766

TEST PLAN
  tabbox plugins and kwin scripts can be installed from knewstuff
  again and can be successfully loaded

REPOSITORY
  R108 KWin

BRANCH
  phab/packageplugins

REVISION DETAIL
  https://phabricator.kde.org/D4202

AFFECTED FILES
  CMakeLists.txt
  kcmkwin/kwintabbox/main.cpp
  packageplugins/CMakeLists.txt
  packageplugins/scripts/CMakeLists.txt
  packageplugins/scripts/kwin-packagestructure-scripts.desktop
  packageplugins/scripts/scripts.cpp
  packageplugins/scripts/scripts.h
  packageplugins/windowswitcher/CMakeLists.txt
  packageplugins/windowswitcher/kwin-packagestructure-windowswitcher.desktop
  packageplugins/windowswitcher/windowswitcher.cpp
  packageplugins/windowswitcher/windowswitcher.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170119/223e112a/attachment.html>


More information about the Plasma-devel mailing list