[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

David Faure noreply at phabricator.kde.org
Thu Jan 19 09:14:46 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in iconapplet.cpp:159
> There you would usually have a filename that makes sense.

No, not necessarily. You can point to the root of a FTP server with ftp://ftp.kde.org/  and you can even point to your home dir on an FTP server with ftp://user@host (and no trailing slash).

Similarly there's smb://workgroup or smb://host (I forgot the exact syntax for workgroups), no filename.

Why not handle any case without a filename in the same way, http or not?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170119/b18149c2/attachment.html>


More information about the Plasma-devel mailing list