[Differential] [Request, 1 line] D4197: Delete KCModule before deleting QApplication

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently the dialog just leaks. As a top level window it should get
  cleaned up by the QApplication destructor.
  
  This hopefully fixes a bug where a QMenu in QML (a top level window with
  no parent) gets deleted by both QApplication and the KCM closing the
  QQuickView which then deletes every QML Element including the menu.

TEST PLAN
  KCM's still load, everything looks the same
  Hopefully Jan can confirm if this fixes the network KCM crash.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4197

AFFECTED FILES
  kcmshell/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170118/6a43fbc5/attachment.html>