Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

Alexander Volkov a.volkov at rusbitech.ru
Wed Jan 18 20:36:11 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/
-----------------------------------------------------------

Review request for Plasma.


Repository: kio-extras


Description
-------

QImageReader::setScaledSize() allows to use fast downscaling
for jpeg images (by setting jpeg_decompress_struct::scale_denom).
QImageReader::setQuality(0) sets dct_method to JDCT_IFAST and
do_fancy_upsampling to FALSE, although these parameters don't
really influence on decoding speed, also as do_block_smoothing
which is not used by Qt.

QImageReader::setAutoTransform() allows to apply the rotation
from EXIF data. It was introduced in Qt 5.5, so bump the
required Qt version.


Diffs
-----

  CMakeLists.txt be305274984321b93e05feeeb6d09490b33a43cc 
  thumbnail/CMakeLists.txt 92eb3c7ae98660eb00e33fbe608de1580ea75912 
  thumbnail/jpegcreator.h 5cab30ff6a0881863ec66d739063f6dbfb4a48f7 
  thumbnail/jpegcreator.cpp 9191fbacd21c65c9fc845fd7c77365005cd8df00 

Diff: https://git.reviewboard.kde.org/r/129851/diff/


Testing
-------


Thanks,

Alexander Volkov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170118/7dc9c45c/attachment.html>


More information about the Plasma-devel mailing list