[Differential] [Commented On] D4191: Only use Qt's DBusMenuBar in Qt >= 5.7

[Martin Gräßlin]

graesslin added a comment.


  It looks like it wasn't the only usage...
  
    [ 58%] Building CXX object autotests/CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kfontsettingsdata.cpp.o
    18:46:32 [ 60%] /home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/kdeplatformtheme.cpp: In function 'bool checkDBusGlobalMenuAvailable()':
    18:46:32 /home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/kdeplatformtheme.cpp:67:34: error: invalid use of incomplete type 'class QDBusConnectionInterface'
    18:46:32      return connection.interface()->isServiceRegistered(registrarService);
    18:46:32                                   ^
    18:46:32 In file included from /srv/jenkins/install/ubuntu/x86_64/g++/stable-kf5-qt5/qt5/inst/usr/include/QtDBus/QDBusConnection:1:0,
    18:46:32                  from /home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/kdeplatformtheme.cpp:43:
    18:46:32 /srv/jenkins/install/ubuntu/x86_64/g++/stable-kf5-qt5/qt5/inst/usr/include/QtDBus/qdbusconnection.h:62:7: note: forward declaration of 'class QDBusConnectionInterface'
    18:46:32  class QDBusConnectionInterface;
    18:46:32        ^
    18:46:32 Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kdirselectdialog.cpp.o
    18:46:32 [ 62%] Building CXX object autotests/CMakeFiles/kdirselectdialog_unittest.dir/__/src/platformtheme/kfiletreeview.cpp.o
    18:46:33 /home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/kdeplatformtheme.cpp: At global scope:
    18:46:33 /home/jenkins/sources/plasma-integration/stable-kf5-qt5/src/platformtheme/kdeplatformtheme.cpp:70:13: warning: 'bool isDBusGlobalMenuAvailable()' defined but not used [-Wunused-function]
    18:46:33  static bool isDBusGlobalMenuAvailable()
    18:46:33              ^
    18:46:33 src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/build.make:54: recipe for target 'src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o' failed
    18:46:33 make[2]: *** [src/platformtheme/CMakeFiles/KDEPlasmaPlatformTheme.dir/kdeplatformtheme.cpp.o] Error 1

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4191

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, bshah
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170118/dc48de90/attachment-0001.html>