[Differential] [Request, 34 lines] D4172: Generate DBusMenu Interface for libdbusmenuqt
David Edmundson
noreply at phabricator.kde.org
Tue Jan 17 14:38:35 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This not only makes the code cleaner but more importantly avoids plasma
making a blocking DBus call to a client in the QDBusInterface constructor
which does a blocking call to Introspect
TEST PLAN
Ran my test app with the dynamic menu. Everything was still fine
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.9
REVISION DETAIL
https://phabricator.kde.org/D4172
AFFECTED FILES
libdbusmenuqt/CMakeLists.txt
libdbusmenuqt/dbusmenuimporter.cpp
libdbusmenuqt/dbusmenuimporter.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170117/051659db/attachment.html>
More information about the Plasma-devel
mailing list