[Differential] [Request, 4 lines] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current code had height: button.height * 1.2
  then centered the button within it, which can result in non-pixel
  aligned y values, leading to rendering issues.
  
  We don't need to specify the height explicitly, it's done by ListItem if
  we fix the underlying binding loop. This gives the delegate the correct
  size of button height + margins.
  
  BUG: 375137

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4166

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170116/dde74ec0/attachment-0001.html>