[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile
David Faure
noreply at phabricator.kde.org
Mon Jan 16 16:14:34 UTC 2017
dfaure added inline comments.
INLINE COMMENTS
> iconapplet.cpp:159
>
> - // TODO use kio stat job which also works for remote stuff
> - QMimeDatabase db;
> - const QMimeType mimeType = db.mimeTypeForUrl(m_url);
> + // TODO use kio stat job which also works for remote stuff
> + QMimeDatabase db;
Isn't this TODO exactly what you implemented now?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4157
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170116/e7776b64/attachment.html>
More information about the Plasma-devel
mailing list