[Differential] [Commented On] D4070: Changes to global menu applet

[Kai Uwe Broulik]

broulik added a comment.


  I just noticed when I change the setting in the KCM the icon changes to the warning icon but the button stays enabled, only if I restart plasma the button is disabled

INLINE COMMENTS

> appmenuapplet.h:69
> +    bool appletEnabled() const;
> +    void updateAppletEnabled();
> +

Needs to be a slot:

  public slots:
      void updateAppletEnabled();

that's why your connection doesn't work

> main.qml:120
>  
> +    Plasmoid.toolTipSubText: !appletEnabled ? i18n("Application Menu Widget is disabled in settings.\n\nGo to Settings > Application Style > Fine Tuning(tab) to enable it again.") : ""
> +

Go to System Settings → Application Style → Fine Tuning (tab) to enable it. (I would still love if you could add a way for the user to open that KCM, perhaps in context menu?)

> main.qml:33
>  
> -    readonly property bool compactView: plasmoid.configuration.compactView
> +    property bool appletEnabled: plasmoid.nativeInterface.appletEnabled
>  

Make it readonly property

> main.qml:122
> +
> +        onMenuAvailable: {
> +            if (appletEnabled) {

Can we make it a binding instead of manually onFooChanged?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4070

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, davidedmundson
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170111/0f784519/attachment.html>